Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): 未読の通知があるときにfaviconに点をつけて目立たせることができるように #13970

Open
wants to merge 46 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Jun 12, 2024

What

かいてあるとおり

image

この点は、点の周りのfaviconを切り抜いて描画されるので、周りの色に影響されにくくちゃんと見えやすいようになってます

image

Cherry-picked from https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/474

Why

Fix #13604

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.68%. Comparing base (7c22a64) to head (fe1de07).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13970       +/-   ##
============================================
+ Coverage    65.35%   77.68%   +12.32%     
============================================
  Files         1004      183      -821     
  Lines       115321    25411    -89910     
  Branches      5506      487     -5019     
============================================
- Hits         75369    19740    -55629     
+ Misses       39925     5664    -34261     
+ Partials        27        7       -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review June 12, 2024 10:40
@kakkokari-gtyih
Copy link
Contributor Author

FavIconFavicon が入り乱れてるの気になるな

@syuilo
Copy link
Member

syuilo commented Jun 13, 2024

「favicon」で一つのワード

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

(off-topic)

image

@ChaoticLeah
Copy link
Contributor

Just a heads up we have refined this a bit more and extended this functionality a bit here if you are interested.
https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/553

@kakkokari-gtyih
Copy link
Contributor Author

たぶんいける気がする

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

新しい通知があるときにはfaviconに点をつける
4 participants