Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): Remove @types/node-fetch #13948

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented Jun 4, 2024

What

@types/node-fetchを消して pnpm install するときに出る警告を解決します。

Why

Since 3.x types are bundled with node-fetch, so you don't need to install any additional packages.
https://github.com/node-fetch/node-fetch?tab=readme-ov-file#typescript

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jun 4, 2024
Copy link
Contributor

github-actions bot commented Jun 4, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.90%. Comparing base (43cccaa) to head (ff9fef4).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13948       +/-   ##
============================================
- Coverage    77.84%   64.90%   -12.95%     
============================================
  Files          185      987      +802     
  Lines        25595   112658    +87063     
  Branches       487     4484     +3997     
============================================
+ Hits         19924    73116    +53192     
- Misses        5664    39511    +33847     
- Partials         7       31       +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tai-cha tai-cha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確かに現行では"node-fetch": "3.3.2",が導入されていて必要なさそうですね👍🏻

@syuilo syuilo merged commit 00b2133 into misskey-dev:develop Jun 22, 2024
27 checks passed
@syuilo
Copy link
Member

syuilo commented Jun 22, 2024

🙏🏻

@woxtu woxtu deleted the node-fetch branch June 22, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants