Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): 通報の管理UIを改善 #13898

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented May 28, 2024

What

image

Cherry-picked from taiyme#222

Why

狭小画面で表示が崩れる問題があったため(Issueがあった気がするけど見つからなかった)

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js labels May 28, 2024
@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented May 28, 2024

バックエンドはたぶんスキーマがたりてないのを修正しただけだと思う まだあった

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 1.89394% with 259 lines in your changes missing coverage. Please review.

Project coverage is 41.87%. Comparing base (3b075c9) to head (a032f85).

Files Patch % Lines
packages/frontend/src/components/MkAbuseReport.vue 0.00% 230 Missing ⚠️
packages/frontend/src/pages/admin/abuses.vue 0.00% 21 Missing ⚠️
.../src/core/entities/AbuseUserReportEntityService.ts 12.50% 7 Missing ⚠️
...c/server/api/endpoints/admin/abuse-user-reports.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13898       +/-   ##
============================================
+ Coverage    20.46%   41.87%   +21.41%     
============================================
  Files          701     1525      +824     
  Lines        98652   194751    +96099     
  Branches      1025     3579     +2554     
============================================
+ Hits         20185    81561    +61376     
- Misses       77946   112647    +34701     
- Partials       521      543       +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 28, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -901,6 +901,9 @@
                             "$ref": "#/components/schemas/UserDetailedNotMe"
                           }
                         ]
+                      },
+                      "forwarded": {
+                        "type": "boolean"
                       }
                     },
                     "required": [
@@ -912,7 +915,8 @@
                       "targetUserId",
                       "assigneeId",
                       "reporter",
-                      "targetUser"
+                      "targetUser",
+                      "forwarded"
                     ]
                   }
                 }

Get diff files from Workflow Page

Co-authored-by: taiy <[email protected]>
@zyoshoka
Copy link
Contributor

i18n.ts.forwardReportIsAnonymous が消えてしまっていますが意図的ですかね?

@kakkokari-gtyih
Copy link
Contributor Author

i18n.ts.forwardReportIsAnonymous が消えてしまっていますが意図的ですかね?

きえてた

@taiyme
Copy link
Contributor

taiyme commented May 29, 2024

i18n.ts.forwardReportIsAnonymous が消えてしまっていますが意図的ですかね?

きえてた

これは意図的に消してます。
UIの都合と、(自分のフォークを利用しているサーバー群では)あまり匿名であることを明記する必要性が無いので

ついでに聞きたいんですが「リモートサーバーに通報を転送」はtargetUserが属しているサーバーに通報を飛ばす機能、という認識で合ってますかね?

@kakkokari-gtyih
Copy link
Contributor Author

これは意図的に消してます。
UIの都合と、(自分のフォークを利用しているサーバー群では)あまり匿名であることを明記する必要性が無いので

Misskeyとしては掲載されていた以上消すのは何か問題ありそうなのでおいとく
UIは後で確認して適宜調整する

@kakkokari-gtyih
Copy link
Contributor Author

ついでに聞きたいんですが「リモートサーバーに通報を転送」はtargetUserが属しているサーバーに通報を飛ばす機能、という認識で合ってますかね?

これはその認識で間違いなさそう

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants