Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): /tags/user-tagsを統合 #13868

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

What

image

Why

Fix #13859

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 80 lines in your changes missing coverage. Please review.

Project coverage is 20.06%. Comparing base (8b163cd) to head (286b524).
Report is 1 commits behind head on develop.

Files Patch % Lines
packages/frontend/src/pages/tag.note.vue 0.00% 34 Missing and 1 partial ⚠️
packages/frontend/src/pages/tag.vue 0.00% 34 Missing ⚠️
packages/frontend/src/pages/tag.user.vue 0.00% 5 Missing ⚠️
packages/frontend/src/pages/explore.users.vue 0.00% 2 Missing ⚠️
packages/frontend/src/router/definition.ts 0.00% 2 Missing ⚠️
...s/global/MkMisskeyFlavoredMarkdown.stories.impl.ts 0.00% 1 Missing ⚠️
...src/components/global/MkMisskeyFlavoredMarkdown.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13868       +/-   ##
============================================
- Coverage    38.78%   20.06%   -18.73%     
============================================
  Files         1544      723      -821     
  Lines       190344   100255    -90089     
  Branches      2402     1051     -1351     
============================================
- Hits         73834    20118    -53716     
+ Misses      115947    79594    -36353     
+ Partials       563      543       -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

konfurikuto kaisho

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消( #13859 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tagsとuser-tagsのページを簡単に切り替えられるようにして欲しい
1 participant