enhance(backend): antennas/updateの必須項目をantennaIdのみに #13542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -16111,16 +16111,7 @@
}
},
"required": [
- "antennaId",
- "name",
- "src",
- "keywords",
- "excludeKeywords",
- "users",
- "caseSensitive",
- "withReplies",
- "withFile",
- "notify"
+ "antennaId"
]
}
} |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13542 +/- ##
============================================
- Coverage 77.90% 66.03% -11.87%
============================================
Files 186 988 +802
Lines 25294 115272 +89978
Branches 484 5723 +5239
============================================
+ Hits 19705 76121 +56416
- Misses 5582 37715 +32133
- Partials 7 1436 +1429 ☔ View full report in Codecov by Sentry. |
syuilo
reviewed
Mar 8, 2024
| @@ -112,7 +114,7 @@ export default class extends Endpoint<typeof meta, typeof paramDef> { // eslint- | |||
| await this.antennasRepository.update(antenna.id, { | |||
| name: ps.name, | |||
| src: ps.src, | |||
| userListId: userList ? userList.id : null, | |||
| userListId: ps.userListId ? userList ? userList.id : null : undefined, | |||
There was a problem hiding this comment.
ほんとですね...、 ps.userListId !== undefined で比較するように変更してみました。
|
🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
antennas/updateの必須項目をantennaIdのみに変更しました。Why
#13398 にもある通りすべて必要だと更新が大変な場合がある為
Additional info (optional)
userListIdに関してはsrcがlistに指定されている前提でのみ更新を行う都合上、srcをallなどに変更した後にuserListIdを更新しようとするとnullになるようになっています。また、
srcがすでにlistに設定されていて、userListIdのみの更新リクエストが来た場合はデータベースから取得したアンテナのsrcがlistかで判断しています。なにか問題がありましたら教えていただけると幸いです。
Checklist