Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Micropub #13144

Open
wants to merge 37 commits into
base: develop
Choose a base branch
from

Conversation

chocolate-pie
Copy link
Contributor

@chocolate-pie chocolate-pie commented Feb 2, 2024

What

Micropub (IndieWeb Living Standard 25 July 2020)のサポートを追加

Why

Closes #9523

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/backend:test labels Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: Patch coverage is 17.80455% with 614 lines in your changes are missing coverage. Please review.

Project coverage is 64.36%. Comparing base (f8261a1) to head (c75569d).
Report is 438 commits behind head on develop.

Files Patch % Lines
...ckend/src/server/micropub/MicropubServerService.ts 16.07% 590 Missing ⚠️
packages/backend/src/server/FileServerService.ts 0.00% 21 Missing ⚠️
packages/backend/src/server/ServerService.ts 33.33% 2 Missing ⚠️
...ages/backend/src/server/web/ClientServerService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13144       +/-   ##
============================================
- Coverage    79.95%   64.36%   -15.59%     
============================================
  Files          956      987       +31     
  Lines       108864   111504     +2640     
  Branches      8413     4369     -4044     
============================================
- Hits         87045    71775    -15270     
- Misses       21819    39697    +17878     
- Partials         0       32       +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 2, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@chocolate-pie chocolate-pie marked this pull request as ready for review February 2, 2024 12:25
@tamaina
Copy link
Contributor

tamaina commented Feb 8, 2024

本体のコード一言一句見てないけどテスト動いてるしApprove

@syuilo
Copy link
Member

syuilo commented Jun 22, 2024

Micropubが何なのかよく分かってないわね

@chocolate-pie
Copy link
Contributor Author

簡単に言うとノートの投稿をソフトウェアが個別で提供しているAPIを意識せずにより簡単にできるようにした仕様で、
拡張機能などでMisskeyに限らずデータの共有とかは簡単にできるようになります。しかしMicropubは今のところ特に著名なソフトウェアが実装しているわけでもありませんしActivityPub C2S APIもPleromaで久しくメンテナンスされていないようなので別に実装しなくてもいいのかもしれません。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Micropub APIのサポート
3 participants