⚡️ Speed up _check_crop_coord()
by 82% in scanpy/plotting/_tools/scatterplots.py
#36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
_check_crop_coord()
inscanpy/plotting/_tools/scatterplots.py
📈 Performance improved by
82%
(0.82x
faster)⏱️ Runtime went down from
57.20μs
to31.50μs
Explanation and details
(click to show)
The changes to the code will focus on memory optimization and avoidable operations for the Python interpreter. In Python, it's faster to scale variables individually than using a generator in a tuple constructor since it avoids creating an intermediate generator object.
Here is your optimized code.
As you can see, the logic remains exactly the same, the function simply avoids creating the intermediate generator object when the tuple is being created. This should marginally increase the speed of your function.
Correctness verification
The new optimized code was tested for correctness. The results are listed below.
🔘 (none found) − ⚙️ Existing Unit Tests
✅ 16 Passed − 🌀 Generated Regression Tests
(click to show generated tests)