Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send http error exception to logger #43

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

SylvainMorel
Copy link

We want better logging of http errors.

  • Change logger.e so that it can take any type of Exception, instead of PlaybackException
  • Send http error exceptions to logger, so the app can log the response code and uri

Change logger.e to take any exception type
@SylvainMorel SylvainMorel merged commit d24faaf into mirego-main Aug 4, 2023
@SylvainMorel SylvainMorel deleted the http_error_send_exception_logger branch August 4, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant