Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separate integrations tab #228

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

rpmccarter
Copy link
Contributor

No description provided.

mint.json Outdated Show resolved Hide resolved
mint.json Outdated
Comment on lines 47 to 50
{
"name": "Mintlify API",
"url": "api-reference"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit weird imo to bundle chat into api reference and also with the API reference not being super robust. Can we move these into advanced?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted with @hahnbeelee about this - the widget is technically an "API". I initially gave widget its own tab but that looked weird with only one page. Happy to just place this in advanced for now until we have more widget/api features, but then I do think we should separate these two out and give them a dedicated tab

Copy link
Member

@handotdev handotdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rpmccarter rpmccarter merged commit 61727bf into main Jul 30, 2024
1 check passed
@rpmccarter rpmccarter deleted the ronan/separate-integrations-tab branch July 30, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants