This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Websockets middleware #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit updates the base image in the Dockerfile to the latest LTS version of nodejs
Similar to the fix for the generic auth-proxy: https://github.com/ministryofjustice/analytics-platform-auth-proxy but in addition it applied an authentication check to the websocket. This is non-standard as a normal application would use the header sec-websocket-key to ensure the incoming websocket connection was solicited, but rstudio relies on a cookie header so we need to ensure that someone is authenticated and authorised before injecting the cookie header to the downstream rstudio server.
To address security alert
|
tested in-cluster against my own rstudio and it works 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the fix for the generic auth-proxy:
https://github.com/ministryofjustice/analytics-platform-auth-proxy but in
addition it applies an authentication check to the websocket. This is
non-standard as a normal application would use the header sec-websocket-key to
ensure the incoming websocket connection was solicited, but rstudio relies on a
cookie header so we need to ensure that someone is authenticated and authorised
before injecting the cookie header to the downstream rstudio server.
Also: