Session expires after 1 hour (by default) #15
Conversation
app/config.js
Outdated
| @@ -20,6 +20,10 @@ config.session = { | |||
| resave: true, | |||
| saveUninitialized: true, | |||
| secret: process.env.COOKIE_SECRET || 'shh-its-a-secret', | |||
| cookie: { | |||
| // In milliseconds. Defaults to 8 hours | |||
| maxAge: (Number.parseInt(process.env.COOKIE_MAXAGE, 10) || 28800) * 1000, | |||
There was a problem hiding this comment.
I think if process.env.COOKIE_MAXAGE is undefined, this will error rather than defaulting as parseInt() will choke.
Instead maybe do something like cookieSeconds: process.env.COOKIE_MAXAGE || 28800 and then multiply * 1000 after.
I think.
There was a problem hiding this comment.
Nope. Ignore. All is well.
:disappear:
There was a problem hiding this comment.
No worries. I tested from the console, etc... and it seems like Number.parseInt() is coping well with whatever you throw at it (as in it would return NaN when it can't convert the thing to an integer).
As NaN is falsey (assuming that is a word) it would then fall back to || 28800, etc...
No worries. Thanks for having a look Clive :)
xoen
force-pushed
the
ag--cookie-max-age
branch
2 times, most recently
from
4959df9
to
27ef62b
Compare
|
@axemonkey FYI: As per discussion with @andyhd earlier I've reduced the expiration time to 1 hour. Merging this. |
Can be configured by setting the `COOKIE_MAXAGE` environment variable to the number of seconds after which cookie session will expire.
xoen
force-pushed
the
ag--cookie-max-age
branch
from
27ef62b
to
017524d
Compare
xoen
changed the title
Can be configured by setting the
COOKIE_MAXAGEenvironment variable tothe number of seconds after which cookie session will expire.