This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Check authorised user is the expected user #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoen
reviewed
Aug 10, 2017
routes/index.js
Outdated
| function authorisedUser(req) { | ||
|
|
||
| if (req && req.user && req.user.nickname) { | ||
| return req.user.nickname.toLowerCase() == env.USER; |
There was a problem hiding this comment.
As this is JS (😱), I would use === here to be on the safe side.
There was a problem hiding this comment.
== coerces the type of the operands, which can be a problem when comparing strings and integers, for example, but it's not a problem here. But I will change this for best practices sake.
|
See comment on equality but as far as I can see looks good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users were able to login to other users' RStudio instances.
This prevents that.
Users can still login to their own RStudio instance, but get a 403 "Forbidden" error if they login to another user's RStudio.