Enable edit pool when multiple pools exist #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c7ef20
to
52440a9
Compare
9133b01
to
581085e
Compare
cniackz
approved these changes
Jan 31, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue summary
When multiple pools are enabled in a MinIO tenant, editing and saving is not possible through the MinIO Operator Console.
See #1951
Test summary
Reproduce issue on master
Test 0 - On multi-pool deployment, observe Edit Pool fail
Fix on enable-edit-pool branch
Test 1 - Expand and Edit pool - change Volume Size and Storage Class
Test 2 - Expand and Edit pool - change Security Context and Custom Runtime Configurations
Test 3 - Expand and Edit pool - change Pod Placement
Verbose tests here:
https://github.com/allanrogerr/public/wiki/operator%E2%80%901951
Fixes: #1951