-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command for uploading file to SUBNET issue #4854
Conversation
2d50c49
to
0dd56f8
Compare
f63d925
to
51555ea
Compare
9b3b939
to
c70bb53
Compare
Should we apply compression if not already compressed? Other than the reduced transfer size, it has the added benefit that it will wrap potentially harmful files and not be directly executable. The server should not do anything do decompress, but we add a field just to be nice. Adding it is pretty trivial:
|
6b29de6
to
4d14664
Compare
mc support upload --issue <issueNum> --comment <msg> <alias> </path/to/file> Will upload the given file to the given SUBNET issue
and a few minor improvements like changing year in copyright notice and command usage.
4d14664
to
acd8c2e
Compare
Have implemented this. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
mc support upload --issue <issueNum> --comment <msg> <alias> </path/to/file>
Will upload the given file to the given SUBNET issue
The file will be compressed using
zstd
before upload.Motivation and Context
For customer's ease of sharing required logs to SUBNET issues
How to test this PR?
mc support upload --issue <issueNum> --comment <msg> <alias> </path/to/file>
Types of changes
Checklist:
commit-id
orPR #
here)