Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show net info spinner in health diagnostics #4741

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

anjalshireesh
Copy link
Contributor

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the [Apache 2 license] (https://www.apache.org/licenses/LICENSE-2.0).
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Show net info spinner in health diagnostics

Motivation and Context

Latest version of minio returns the network hardware info from each server.
Show a spinner for this category of data as well.

How to test this PR?

Requires minio/minio#18381

  • Generate health report (mc support diag <alias> --airgap)
  • Verify that a spinner is added for Net info in output of the command

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@anjalshireesh anjalshireesh marked this pull request as ready for review November 2, 2023 14:17
@harshavardhana harshavardhana merged commit b7dc9cc into minio:master Nov 2, 2023
5 checks passed
@anjalshireesh anjalshireesh deleted the health branch November 3, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants