Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow registration of play cluster #4647

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

anjalshireesh
Copy link
Contributor

Description

Since play is a public demo cluster, it should not be allowed to register with subnet.

How to test this PR?

Try to register the play cluster mc license register play --api-key <api-key>

This should fail with error play is a public demo cluster; cannot be registered

Registration of any other cluster should not show this error and should work as expected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Since play is a public demo cluster, it should not be allowed to
register with subnet.
@anjalshireesh anjalshireesh marked this pull request as ready for review July 25, 2023 16:33
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified

@harshavardhana harshavardhana merged commit 6b8680a into minio:master Jul 26, 2023
5 checks passed
@anjalshireesh anjalshireesh deleted the play branch July 26, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants