Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade madmin-go/v3 to 3.0.4 #4618

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

anjalshireesh
Copy link
Contributor

Description

In order to capture realtime metrics in health report

Motivation and Context

Capture realtime metrics in health report

How to test this PR?

Depends on minio/minio#17516

  • generate health report using mc support diag <alias> --airgap
  • Extract it and verify that it contains a metrics node under minio -> info that contains realtime metrics
  • Verify that the hostnames / ip-addresses under this node are anonymized

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit eebdcdf into minio:master Jun 28, 2023
5 checks passed
bjw-s pushed a commit to bjw-s/dotfiles that referenced this pull request Jun 30, 2023
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [mc](https://togithub.com/minio/mc) | patch | `2023-06-23T18-12-07Z`
-> `2023-06-28T21-54-17Z` |

---

### Release Notes

<details>
<summary>minio/mc (mc)</summary>

###
[`v2023-06-28T21-54-17Z`](https://togithub.com/minio/mc/releases/tag/RELEASE.2023-06-28T21-54-17Z):
Bug Fix Release

[Compare
Source](https://togithub.com/minio/mc/compare/RELEASE.2023-06-23T18-12-07Z...RELEASE.2023-06-28T21-54-17Z)

##### What's Changed

- fix: allow cluster bucket export to export single bucket by
[@&#8203;r-scheele](https://togithub.com/r-scheele) in
[minio/mc#4614
- improve user messaging in 'support perf' and 'mc rm --dry-run' by
[@&#8203;harshavardhana](https://togithub.com/harshavardhana) in
[minio/mc#4617
- Fix issues related to 'mc admin svcacct list --json' cmd by
[@&#8203;kaankabalak](https://togithub.com/kaankabalak) in
[minio/mc#4619
- Upgrade madmin-go/v3 to 3.0.4 by
[@&#8203;anjalshireesh](https://togithub.com/anjalshireesh) in
[minio/mc#4618

**Full Changelog**:
minio/mc@RELEASE.2023-06-23T18-12-07Z...RELEASE.2023-06-28T21-54-17Z

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNDQuMiIsInVwZGF0ZWRJblZlciI6IjM1LjE0NC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: bjw-s-bot <87358111+bjw-s-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants