Add --disable, --enable and --prefix to ilm commands #4209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing the prefix in the aliased url is problematic for ilm edit command when the user wants to modify something in the ILM rule: no prefix in the url means the user wants to set an empty prefix or maybe nothing. To fix this, add --prefix flag and make it a default choice in the document. Also, ilm edit will try to only apply passed flags. LifecycleOptions fields are all pointers to apply only non nil fields to the ILM rule.
harshavardhana
approved these changes
Aug 15, 2022
|
We may need update of docs as well @vadmeste |
5 tasks
adfost
pushed a commit
to adfost/mc
that referenced
this pull request
Oct 28, 2022
Passing the prefix in the aliased url is problematic for ilm edit command when the user wants to modify something in the ILM rule: no prefix in the url means the user wants to set an empty prefix or maybe nothing. To fix this, add --prefix flag and make it a default choice in the document. Also, ilm edit will try to only apply passed flags. LifecycleOptions fields are all pointers to apply only non nil fields to the ILM rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing the prefix in the aliased url is problematic for ilm edit
command when the user wants to modify something in the ILM rule: no
prefix in the url means the user wants to set an empty prefix or maybe
nothing. To fix this, add --prefix flag and make it a default choice in
the document.
Also, ilm edit will try to only apply passed flags. LifecycleOptions
fields are all pointers to apply only non nil fields to the ILM rule.