Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for several issues related to SFTP and LDAP #1252

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Changes for several issues related to SFTP and LDAP #1252

wants to merge 3 commits into from

Conversation

djwfyi
Copy link
Collaborator

@djwfyi djwfyi commented Jun 20, 2024 •
edited
Loading

  • Adds info the docs about recent changes to LDAP and SFTP authentication
  • Adds new config/envvar parameter
  • Adds new sftp option for server
  • Adds new example for forcing ldap or sa auth to SFTP
  • Adds new example for using certificate authority for auth to SFTP

Closes #1240
Closes #1229
Closes #1226
Closes #1208

Staged:

@djwfyi djwfyi self-assigned this Jun 20, 2024
ravindk89
ravindk89 requested changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something isn't clicking w/ the procedure to set up. A few open questions.

source/includes/k8s/file-transfer-protocol-k8s.rst Outdated Show resolved Hide resolved
source/includes/k8s/file-transfer-protocol-k8s.rst Outdated Show resolved Hide resolved
source/includes/k8s/file-transfer-protocol-k8s.rst Outdated Show resolved Hide resolved
source/includes/k8s/file-transfer-protocol-k8s.rst Outdated Show resolved Hide resolved
@djwfyi
Adds info the docs about recent changes to LDAP and SFTP authentication
17001e7 
Adds new config/envvar parameter
Adds new sftp option for server
Adds new example for forcing ldap or sa auth to SFTP

Closes #1240
Closes #1229
Closes #1226
@djwfyi
Adds info for connecting to SFTP by a certificate key file
e3bd984 
Closes #1208
@djwfyi
Applying PR feedback
4e718d8
feorlen
feorlen approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@feorlen feorlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Words look good! I am very fuzzy on the mTLS bit, someone else may have more useful opinions there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravindk89 ravindk89 ravindk89 requested changes

@feorlen feorlen feorlen approved these changes

@zveinn zveinn Awaiting requested review from zveinn

Requested changes must be addressed to merge this pull request.

Assignees

@djwfyi djwfyi

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@djwfyi @feorlen @ravindk89