Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for several issues related to SFTP and LDAP #1252

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Changes for several issues related to SFTP and LDAP #1252

merged 4 commits into from
Jul 15, 2024

Conversation

djwfyi
Copy link
Collaborator

@djwfyi djwfyi commented Jun 20, 2024

  • Adds info the docs about recent changes to LDAP and SFTP authentication
  • Adds new config/envvar parameter
  • Adds new sftp option for server
  • Adds new example for forcing ldap or sa auth to SFTP
  • Adds new example for using certificate authority for auth to SFTP

Closes #1240
Closes #1229
Closes #1226
Closes #1208

Staged:

@djwfyi djwfyi self-assigned this Jun 20, 2024
Copy link
Collaborator

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something isn't clicking w/ the procedure to set up. A few open questions.

source/includes/k8s/file-transfer-protocol-k8s.rst Outdated Show resolved Hide resolved
source/includes/k8s/file-transfer-protocol-k8s.rst Outdated Show resolved Hide resolved
source/includes/k8s/file-transfer-protocol-k8s.rst Outdated Show resolved Hide resolved
source/includes/k8s/file-transfer-protocol-k8s.rst Outdated Show resolved Hide resolved
Adds new config/envvar parameter
Adds new sftp option for server
Adds new example for forcing ldap or sa auth to SFTP

Closes #1240
Closes #1229
Closes #1226
Copy link
Collaborator

@feorlen feorlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Words look good! I am very fuzzy on the mTLS bit, someone else may have more useful opinions there.

@zveinn
Copy link

zveinn commented Jul 10, 2024

LGTM

Copy link
Collaborator

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wont hold the PR on this, but I'm still stumbling a bit on our presentation of the key requirements. If we can slightly clarify that now, great. Otherwise we can launch and then revise as necessary.

source/includes/k8s/file-transfer-protocol-k8s.rst Outdated Show resolved Hide resolved
source/includes/k8s/file-transfer-protocol-k8s.rst Outdated Show resolved Hide resolved
2. MinIO Server signed by the certificate authority
3. User signed by the certificate authority for the client connecting by SFTP and located in the user's ``.ssh`` folder or equivalent for the operating system

The keys must include a `principals list <https://man.openbsd.org/ssh-keygen#CERTIFICATES>`__ of the user(s) that can authenticate with the key:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All keys? Even the ones MinIO Server uses?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zveinn Can you clarify?

@djwfyi djwfyi merged commit 529e67d into main Jul 15, 2024
@djwfyi djwfyi deleted the ldap-sftp branch July 15, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants