Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MINIO_SERVER_URL to deprecated command list #1251

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

ravindk89
Copy link
Collaborator

For reference by support w/ customers running older MinIO versions

Mostly need this because it sometimes comes up via support, and this lets us reference it while also pushing users to upgrade to versions where this kind of behavior is handled automatically.

For reference by support w/ customers running older MinIO versions
@ravindk89 ravindk89 requested a review from djwfyi June 20, 2024 14:39
Copy link
Collaborator

@djwfyi djwfyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we need the or at all, since it's a bulleted list. But should make those parallel.

source/reference/minio-server/settings/deprecated.rst Outdated Show resolved Hide resolved
source/reference/minio-server/settings/deprecated.rst Outdated Show resolved Hide resolved
@ravindk89
Copy link
Collaborator Author

Not sure if we need the or at all, since it's a bulleted list. But should make those parallel.

I'll take the changes, this was copy-pasted from the commit prior to removal anyways.

Copy link
Collaborator

@djwfyi djwfyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Merge it

:shipit:

@ravindk89 ravindk89 merged commit 9fa014a into main Jun 20, 2024
@ravindk89 ravindk89 deleted the deprecated-MINIO_SERVER_URL branch June 20, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants