Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unbalanced quotes in MINIO_OPTS var, clarify how it is used #1249

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Remove unbalanced quotes in MINIO_OPTS var, clarify how it is used #1249

merged 4 commits into from
Jun 25, 2024

Conversation

marktheunissen
Copy link
Contributor

@marktheunissen marktheunissen commented Jun 18, 2024 •
edited
Loading

  • Please click "Ignore Whitespace" when reviewing, my editor stripped out all the trailing whitespace.
  • Removes an extra " quote
  • Try to explain how MINIO_OPTS works, does that sound right?
  • Add missing : in front of port number

@marktheunissen marktheunissen marked this pull request as ready for review June 18, 2024 05:36
djwfyi
djwfyi requested changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@djwfyi djwfyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this find and this fix!
A suggested change for formatting purposes.

source/reference/minio-server/settings/core.rst Outdated Show resolved Hide resolved
@marktheunissen
Copy link
Contributor Author

Good improvements, thanks!

@ravindk89
Copy link
Collaborator

@djwfyi can you eyeball real quick?

djwfyi
djwfyi reviewed Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@djwfyi djwfyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tidy up suggestions, otherwise looks good to me.

source/reference/minio-server/settings/core.rst Outdated Show resolved Hide resolved
source/reference/minio-server/settings/core.rst Outdated Show resolved Hide resolved
source/reference/minio-server/settings/core.rst Outdated Show resolved Hide resolved
@ravindk89 ravindk89 requested a review from djwfyi June 25, 2024 15:51
djwfyi
djwfyi approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@djwfyi djwfyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ravindk89 ravindk89 merged commit af031f7 into main Jun 25, 2024
@ravindk89 ravindk89 deleted the imbalanced-quote branch June 25, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravindk89 ravindk89 ravindk89 left review comments

@djwfyi djwfyi djwfyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marktheunissen @ravindk89 @djwfyi