Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate sample batch framework config YAML #1242

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Conversation

feorlen
Copy link
Collaborator

@feorlen feorlen commented Jun 11, 2024

Per @shtripat and @vadmeste , the indentation was off. Fixed by generating new examples with

  • mc batch generate play/ replicate
  • mc batch generate play/ keyrotate

The expire example is identical to current mc batch generate play/ expire output.

Error reported by a customer.

The indentation was off, fixed by generating a new example with `mc batch generate play/ replicate`

Error reported by a customer.
@feorlen
Copy link
Collaborator Author

feorlen commented Jun 11, 2024

Note: confirming with eng that the other yaml examples in this directory are correct.

@feorlen feorlen changed the title Regenerate sample replication config in replicate.yaml Regenerate sample batch framework config YAML Jun 11, 2024
Copy link
Collaborator

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is what the command outputs, then if something needs to be fixed lets see it happen in mc first :)

LGTM.

Copy link

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feorlen feorlen merged commit e90efa5 into main Jun 11, 2024
@feorlen feorlen deleted the example-replicate-yaml branch June 11, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants