Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushing pyyaml to 6.0.1 to resolve compat with Python 3.12 #1237

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

ravindk89
Copy link
Collaborator

yaml/pyyaml#736

Python 3.12+ is somewhat broken when trying to install fresh.

Bumping PyYaml to 6.0.1 seems to fix it. There are some warnings that we might have to freeze at Python 3.12 until PyYaml updates to fully support it at some indeterminate time in the future.

@djwfyi @feorlen please test w/ a clean venv (e.g. python -m venv testvenv or something) and make sure that you can still pip install -r requirements.txt and build w/ PyYaml 6.0.1

@feorlen
Copy link
Collaborator

feorlen commented Jun 7, 2024

Will try later today. Wondering if this is related to my recent problem on macOS. I was trying to nuke and pave with fresh 3.12.

Copy link
Collaborator

@djwfyi djwfyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully built Linux and K8s with 6.0.1 on macOS.

@feorlen
Copy link
Collaborator

feorlen commented Jun 7, 2024

I was also successful on macOS, after reinstalling py 3.12.3 and pip.

I get this warning on both linux and k8s:

(node:67067) [DEP0180] DeprecationWarning: fs.Stats constructor is deprecated.
(Use `node --trace-deprecation ...` to show where the warning was created)

and this on k8s

Browserslist: caniuse-lite is outdated. Please run:
  npx browserslist@latest --update-db
  Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating

Running the npx command says No target browser changes but after that I no longer get that warning on k8s.

@ravindk89
Copy link
Collaborator Author

The node stuff might require some fixups in kes-docs-theme, but are noncritical for our purposes.

Will merge this up

@ravindk89 ravindk89 merged commit 0441711 into main Jun 7, 2024
@ravindk89 ravindk89 deleted the PYYAML branch June 7, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants