Change scrape_interval in metrics scraping example #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The examples show `15s`, which is too short for a typical deployment. `60s` is recommended. Also note that this value may need to be increased if there are too many metrics to collect in the specified amount of time. Each scraping operation should complete before the next begins.
feorlen
commented
May 30, 2024
source/operations/monitoring/collect-minio-metrics-using-prometheus.rst
Outdated
Show resolved
Hide resolved
|
This value is in the section about configuring an alert rule. Is
|
|
I think that was intended to show where in the file it should go, so maybe we can just drop those two lines entirely. We state it goes into the Prometheus configuration already. |
ravindk89
approved these changes
May 30, 2024
source/operations/monitoring/collect-minio-metrics-using-prometheus.rst
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples show
15s, which is too short for a typical deployment.60sis recommended. Also note that this value may need to be increased if there are too many metrics to collect in the specified amount of time. Each scraping operation should complete before the next begins.Staged
https://192.241.195.202:9000/staging/scrape_interval/linux/operations/monitoring/collect-minio-metrics-using-prometheus.html#generate-the-scrape-configuration