Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds mc ready to reference docs #1221

Merged
merged 5 commits into from
May 22, 2024
Merged

Adds mc ready to reference docs #1221

merged 5 commits into from
May 22, 2024

Conversation

djwfyi
Copy link
Collaborator

@djwfyi djwfyi commented May 21, 2024

@djwfyi djwfyi requested review from feorlen and ravindk89 May 21, 2024 19:18
@djwfyi djwfyi self-assigned this May 21, 2024
Copy link
Collaborator

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod nits and one clarifying question that we don't necessarily need to block on.

source/reference/minio-mc/mc-ready.rst Outdated Show resolved Hide resolved
source/reference/minio-mc/mc-ready.rst Outdated Show resolved Hide resolved
source/reference/minio-mc/mc-ready.rst Outdated Show resolved Hide resolved
.. mc-cmd:: --maintenance
:optional:

Checks if the cluster can maintain read and write quorum if taken down for maintenance.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if what is taken down? the cluster?

I assume the node that receives the ready command - if a load balancer is involved then it will be hard for the user to know what node is safe to take down.

I wonder if we need guidance to use this with a custom alias for the specific node you want to pop.

Check if the cluster has read quorum
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The following command sends checks that a deployment has sufficient drives available for read operations.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"sends checks" ?

@djwfyi djwfyi merged commit c1bbe71 into main May 22, 2024
@djwfyi djwfyi deleted the mcready branch May 22, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document readiness endpoint
3 participants