Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds information about tiering rules and exclusive access #1220

Merged
merged 5 commits into from
May 22, 2024
Merged

Adds information about tiering rules and exclusive access #1220

merged 5 commits into from
May 22, 2024

Conversation

djwfyi
Copy link
Collaborator

@djwfyi djwfyi commented May 21, 2024

Adds info to the object management page.
Does not restructure the docs at this time.

Partially addresses #1207

Staged:

@djwfyi djwfyi requested review from feorlen and ravindk89 May 21, 2024 18:12
@djwfyi djwfyi self-assigned this May 21, 2024
feorlen
feorlen approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@feorlen feorlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple ideas for your consideration. Otherwise LGTM.

ravindk89
ravindk89 requested changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should restructure the intro a bit. The good info is here, but I think we need to improve how we present it to make it absolutely clear what the consequences are.

source/administration/object-management.rst Outdated Show resolved Hide resolved
source/administration/object-management.rst Outdated Show resolved Hide resolved
ravindk89
ravindk89 reviewed May 21, 2024
View reviewed changes
Copy link
Collaborator

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm - making one more pass at structured guidance. Mostly moving a few things around.

source/administration/object-management.rst Outdated Show resolved Hide resolved
source/administration/object-management.rst Outdated Show resolved Hide resolved
source/administration/object-management.rst Outdated Show resolved Hide resolved
source/administration/object-management.rst Outdated Show resolved Hide resolved
ravindk89
ravindk89 approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod changeups

source/administration/object-management.rst Outdated Show resolved Hide resolved
source/administration/object-management.rst Outdated Show resolved Hide resolved
source/administration/object-management.rst Outdated Show resolved Hide resolved
@djwfyi djwfyi merged commit 76b5bb0 into main May 22, 2024
@djwfyi djwfyi deleted the target-lock branch May 22, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feorlen feorlen feorlen approved these changes

@ravindk89 ravindk89 ravindk89 approved these changes

Assignees

@djwfyi djwfyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@djwfyi @feorlen @ravindk89