attempt to remove plugin from docs #1219

feorlen · 2024-05-16T21:03:01Z

The Kubernetes plugin is gone, this PR replaces the procedures that use kubectl minio in all its various forms. The plugin was referenced on many pages and for many purposes so there is a lot of restructuring involved.

Some procedures no longer have CLI instructions, which can be addressed in subsequent PRs. Everything should have at least one working method, even if it's to use Operator Console.

Remove references to plugin, except for pre-4.5.8 upgrade paths
Move pre-4.5.8 upgrade paths to new child page (currently hidden from TOC, linked in page)
Fill in with new Kustomize, kubectl, and/or Operator Console steps.

A handful of old screen captures still to be updated

Staged:

Fixes #1213

…deploy

source/includes/common/common-k8s-connect-operator-console-no-plugin.rst

source/includes/common/common-k8s-connect-operator-console.rst

ravindk89

Excellent first pass. Mostly tidy-ups.

source/includes/k8s/deploy-operator.rst

source/operations/install-deploy-manage/deploy-minio-tenant.rst

source/operations/install-deploy-manage/upgrade-minio-tenant.rst

ravindk89 · 2024-06-04T16:08:39Z

source/includes/aks/deploy-minio-on-azure-kubernetes-service.rst

@@ -51,5 +48,5 @@ For guidance on connecting ``kubectl`` to AKS, see :aks-docs:`Install kubectl an
 Procedure
 ---------

-.. include:: /includes/common/common-install-operator-kubectl-plugin.rst
+Something Kustomize


Hah.

FWIW the procedure should be exactly identical no matter what. EKS, AKS, and GKS should treat kubectl apply -k github.com/minio/operator identically.

I can also handle this as part of the deplatformization if we want, but if we go that route we have to push this to an independent branch before we go to main

Trying something - same text from k8s (conveniently already an include) as the "Procedure" section for aks, eks, gke.

I'm not entirely sure the console port forwarding instructions are accurate for not-k8s. Also the admonition about only using Kustomize going forward. I could also copy the include content, minus those bits, into the three other pages.

Or is it close enough, given it's all getting yeeted shortly anyway.

Thoughts? @ravindk89 @djwfyi

staged:
aks:
http:https://192.241.195.202:9000/staging/DOCS-1213-upstream/aks/operations/installation.html#procedure

eks:
http:https://192.241.195.202:9000/staging/DOCS-1213-upstream/eks/operations/installation.html#procedure

gke:
http:https://192.241.195.202:9000/staging/DOCS-1213-upstream/gke/operations/installation.html#procedure

IMHO this is good enough.

source/includes/common/common-k8s-connect-operator-console.rst

djwfyi

Wow, what a load of work. Thanks for taking this on.
A number of suggestions for your consideration.
I did not look at staging this pass, but will with the next one.

source/includes/common/common-k8s-connect-operator-console-no-plugin.rst

source/includes/common/common-k8s-connect-operator-console.rst

source/includes/common/common-k8s-operator-console-jwt.rst

source/operations/install-deploy-manage/deploy-minio-tenant.rst

source/operations/install-deploy-manage/expand-minio-tenant.rst

source/operations/install-deploy-manage/upgrade-minio-tenant.rst

shtripat

Mostly looks good. Check @djwfyi 's comments.

…vs Kustomize

ravindk89

I think this is good to go. We can make further clean ups in the IA rewrite pull as needed.

Excellent work.

@djwfyi

comments addressed with changes and other approvals. Thanks @djwfyi !

Fix build warnings from #1219 Some are broken refs that need to point elsewhere. Some are because `openshift`, `eks`, `gke`, `aks` can't see a target that's on a `k8s` page, apparently due to how `operations/installation.rst` is structured. These we are still investigating.

feorlen added 4 commits May 13, 2024 14:48

partial update

8b32cc1

remove plugin page from nav

a7a2bc4

move kustomize content to deploy operator page

2d1fd9a

attempt to remove plugin references, replace with what?

d79d9f2

feorlen marked this pull request as draft May 16, 2024 21:03

feorlen added 21 commits May 17, 2024 16:24

move older upgrade instructions to new page

72ef474

yeet plugin content, needs new kustomize alternatives

b95ca0b

update upgrade tenant

a07fac8

update expand tenant - needs kustomize instructions

3ec4723

update delete tenant -- needs kustomize instructions

0057c02

update upgrade operator - needs kustomize instructions

62199be

update openshift - needs ?

9d0b3b8

update plugin dl url to 5.0.14, latest available

a96691f

update aks/gke/eks - needs kustomize

dd9eb77

update iam/sse

edc2c95

remove plugin proxy mention - needs ?

c740edb

remove plugin pages, except init

9d00643

clean up ugly merge

523d592

Start adding non-plugin steps for Operator deploy/upgrade and Tenant …

f15f328

…deploy

Operator deploy/upgrade, Tenant deploy tested

3f58ef9

upgrade tenant kubectl instructions

ffa06d2

update expand tenant

662ee53

update delete tenant

2471184

spellcheck

b383a1c

fixup

c639e63

Merge branch 'main' into DOCS-1213-upstream

2aa4a98

feorlen marked this pull request as ready for review June 3, 2024 23:40

harshavardhana approved these changes Jun 4, 2024

View reviewed changes

pjuarezd approved these changes Jun 4, 2024

View reviewed changes

shtripat reviewed Jun 4, 2024

View reviewed changes

ravindk89 requested changes Jun 4, 2024

View reviewed changes

djwfyi previously requested changes Jun 4, 2024

View reviewed changes

partial update from review feedback

8071eba

allanrogerr approved these changes Jun 5, 2024

View reviewed changes

shtripat approved these changes Jun 5, 2024

View reviewed changes

feorlen added 4 commits June 5, 2024 22:20

more feedback updates

498b273

might revert later: same k8s operator include for aks,eks,gke procedure

03b9d96

Different steps for tenant originally deployed with Operator Console …

66f5dd0

…vs Kustomize

fix references to plugin for port forwarding

61efe45

feorlen mentioned this pull request Jun 6, 2024

Document TLS Certificates flow with Cert Manager minio/operator#2079

Merged

ravindk89 approved these changes Jun 7, 2024

View reviewed changes

feorlen added 2 commits June 7, 2024 14:55

hide ancient screenshots pending new ones

53ee6bd

Merge branch 'main' into DOCS-1213-upstream

9194895

feorlen merged commit d17c896 into main Jun 7, 2024

feorlen deleted the DOCS-1213-upstream branch June 7, 2024 15:05

This was referenced Jun 7, 2024

[RELEASE] Operator v5.0.15 #1210

Closed

Fix build warnings for Operator pages #1238

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

attempt to remove plugin from docs #1219

attempt to remove plugin from docs #1219

feorlen commented May 16, 2024 •

edited

Loading

ravindk89 left a comment

ravindk89 Jun 4, 2024

feorlen Jun 6, 2024

ravindk89 Jun 7, 2024

djwfyi left a comment

shtripat left a comment

ravindk89 left a comment

attempt to remove plugin from docs #1219

attempt to remove plugin from docs #1219

Conversation

feorlen commented May 16, 2024 • edited Loading

ravindk89 left a comment

Choose a reason for hiding this comment

ravindk89 Jun 4, 2024

Choose a reason for hiding this comment

feorlen Jun 6, 2024

Choose a reason for hiding this comment

ravindk89 Jun 7, 2024

Choose a reason for hiding this comment

djwfyi left a comment

Choose a reason for hiding this comment

shtripat left a comment

Choose a reason for hiding this comment

ravindk89 left a comment

Choose a reason for hiding this comment

feorlen commented May 16, 2024 •

edited

Loading