Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix white-space behaviour of inline code blocks #1205

Merged
merged 2 commits into from
May 13, 2024
Merged

Conversation

rushenn
Copy link
Member

@rushenn rushenn commented May 7, 2024

No description provided.

@rushenn
Copy link
Member Author

rushenn commented May 7, 2024

@ravind Apologise for the late reply, somehow I missed the notification for the Slack thread.

I've added a possible solution for extremely long code blocks within table cells. Please let me know if this resolves the issue.

@rushenn rushenn requested a review from ravindk89 May 7, 2024 07:29
@ravindk89
Copy link
Collaborator

This is definitely better.

Granted for the very long metric names the break looks ugly, but I'm not sure we can do much about that unless we go through and manually break the metrics, which is not something I want to deal with right now.

@djwfyi @feorlen can you confirm this builds/functions as expected on the OSX side of things?

@ravindk89 ravindk89 requested review from feorlen and djwfyi May 13, 2024 20:35
@ravindk89
Copy link
Collaborator

Once one other docs team ensures this builds w/o issues on another arch, we're good to roll this out

@ravindk89 ravindk89 merged commit 80a2886 into minio:main May 13, 2024
@feorlen
Copy link
Collaborator

feorlen commented May 13, 2024

Confirm macOS build is better 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants