Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that mc support perf suspends other S3 API calls for testing #1199

Merged
merged 4 commits into from
May 3, 2024

Conversation

feorlen
Copy link
Collaborator

@feorlen feorlen commented Apr 29, 2024

@feorlen feorlen marked this pull request as draft April 29, 2024 17:00
@feorlen feorlen self-assigned this Apr 29, 2024
@feorlen feorlen marked this pull request as ready for review May 1, 2024 21:29
@feorlen feorlen requested a review from djwfyi May 1, 2024 21:30
@feorlen
Copy link
Collaborator Author

feorlen commented May 1, 2024

@klauspost moved the revised text to the individual drive and net items. Any more that needs to be said?

Copy link
Collaborator

@djwfyi djwfyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative wording to consider. Mostly the three passives in the same sentence gave me pause. But up to you to use or not.

No admonitions is the Right Call™.

source/reference/minio-mc/mc-support-perf.rst Outdated Show resolved Hide resolved
source/reference/minio-mc/mc-support-perf.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@djwfyi djwfyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 LGTM

@feorlen feorlen merged commit 72e56b4 into main May 3, 2024
@feorlen feorlen deleted the mc-support-perf-s3-api branch May 3, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants