Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add concept pages for Scanner and Healing #1192

Merged
merged 7 commits into from
Apr 25, 2024
Merged

Add concept pages for Scanner and Healing #1192

merged 7 commits into from
Apr 25, 2024

Conversation

djwfyi
Copy link
Collaborator

@djwfyi djwfyi commented Apr 19, 2024

Adds concept pages for healing and the scanner.
Updates other related files for better context.

Adds ref links and other related updates.

Closes #1168

Staging info:

@djwfyi djwfyi self-assigned this Apr 19, 2024
eco-minio
eco-minio reviewed Apr 19, 2024
View reviewed changes
source/operations/concepts/scanner.rst Outdated Show resolved Hide resolved
source/operations/concepts/scanner.rst Outdated Show resolved Hide resolved
source/operations/concepts/scanner.rst Outdated Show resolved Hide resolved
source/operations/concepts/scanner.rst Outdated Show resolved Hide resolved
source/operations/concepts/scanner.rst Outdated Show resolved Hide resolved
source/operations/concepts/scanner.rst Outdated Show resolved Hide resolved
source/operations/concepts/scanner.rst Outdated Show resolved Hide resolved
source/operations/concepts/scanner.rst Outdated Show resolved Hide resolved
source/operations/data-recovery/recover-after-drive-failure.rst Outdated Show resolved Hide resolved
source/operations/install-deploy-manage/multi-site-replication.rst Outdated Show resolved Hide resolved
ravindk89
ravindk89 requested changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to tighten up the healing logic , but this is a good first pass

source/operations/concepts.rst Outdated Show resolved Hide resolved
source/operations/concepts.rst Outdated Show resolved Hide resolved
source/operations/concepts/healing.rst Outdated Show resolved Hide resolved
source/operations/concepts/healing.rst Outdated Show resolved Hide resolved
source/operations/concepts/healing.rst Outdated Show resolved Hide resolved
source/operations/concepts/healing.rst Outdated Show resolved Hide resolved
source/operations/concepts/healing.rst Show resolved Hide resolved
source/operations/concepts/healing.rst Outdated Show resolved Hide resolved
source/operations/concepts/healing.rst Outdated Show resolved Hide resolved
source/operations/concepts/healing.rst Outdated Show resolved Hide resolved
feorlen
feorlen reviewed Apr 19, 2024
View reviewed changes
source/glossary.rst Outdated Show resolved Hide resolved
klauspost
klauspost reviewed Apr 23, 2024
View reviewed changes
source/operations/concepts/healing.rst Outdated Show resolved Hide resolved
source/operations/concepts/healing.rst Outdated Show resolved Hide resolved
source/operations/concepts/healing.rst Show resolved Hide resolved
source/operations/concepts/scanner.rst Outdated Show resolved Hide resolved
source/operations/concepts/scanner.rst Outdated Show resolved Hide resolved
source/operations/concepts/scanner.rst Outdated Show resolved Hide resolved
feorlen
feorlen approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@feorlen feorlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted a couple typos, otherwise LGTM
🎉 This is a ton of work, the results look great 🎉

ravindk89
ravindk89 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod Andrea's edits

@djwfyi djwfyi merged commit 9622446 into main Apr 25, 2024
@djwfyi djwfyi deleted the scanner branch April 25, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klauspost klauspost klauspost left review comments

@eco-minio eco-minio eco-minio left review comments

@feorlen feorlen feorlen approved these changes

@ravindk89 ravindk89 ravindk89 approved these changes

@harshavardhana harshavardhana Awaiting requested review from harshavardhana

Assignees

@djwfyi djwfyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve documentation about the scanner
5 participants
@djwfyi @feorlen @klauspost @ravindk89 @eco-minio