Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS-1083: MinIO Server Release RELEASE.2023-12-02T10-51-33Z #1097

Merged
merged 7 commits into from
Jan 2, 2024
Merged

DOCS-1083: MinIO Server Release RELEASE.2023-12-02T10-51-33Z #1097

merged 7 commits into from
Jan 2, 2024

Conversation

ravindk89
Copy link
Collaborator

Summary

Closes #1083

Also reorganizes the batch framework pages. Could use additional refinement, but considering that out of scope for now.

Staged:

ravindk89
ravindk89 commented Dec 26, 2023
View reviewed changes
Copy link
Collaborator Author

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick ping on relevant sections for engineering.

source/administration/batch-framework-job-replicate.rst Show resolved Hide resolved
source/administration/batch-framework-job-replicate.rst Outdated Show resolved Hide resolved
source/administration/batch-framework-job-expire.rst Show resolved Hide resolved
djwfyi
djwfyi approved these changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@djwfyi djwfyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some formatting or wording suggestions to consider.
Maybe surface links from mc-batch-replicate to the administration/batch-replicate docs somewhere.

Otherwise, this LGTM. Don't feel the need to see it again after you address/consider my suggestions.

source/administration/batch-framework-job-expire.rst Outdated Show resolved Hide resolved
source/administration/batch-framework-job-expire.rst Outdated Show resolved Hide resolved
source/administration/batch-framework-job-expire.rst Show resolved Hide resolved
source/administration/batch-framework-job-expire.rst Outdated Show resolved Hide resolved
source/administration/batch-framework-job-expire.rst Outdated Show resolved Hide resolved
source/administration/batch-framework-job-replicate.rst Outdated Show resolved Hide resolved
source/administration/batch-framework-job-replicate.rst Outdated Show resolved Hide resolved
source/administration/batch-framework.rst Outdated Show resolved Hide resolved
source/reference/minio-mc/mc-batch-generate.rst Outdated Show resolved Hide resolved
source/reference/minio-server/settings/notifications/kafka.rst Outdated Show resolved Hide resolved
@ravindk89 ravindk89 self-assigned this Dec 27, 2023
vadmeste
vadmeste reviewed Dec 27, 2023
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

source/administration/batch-framework-job-replicate.rst Outdated Show resolved Hide resolved
source/administration/batch-framework-job-replicate.rst Outdated Show resolved Hide resolved
krisis
krisis reviewed Dec 27, 2023
View reviewed changes
Copy link
Member

@krisis krisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on Batch Expire feature documentation!

source/administration/batch-framework-job-expire.rst Show resolved Hide resolved
source/administration/batch-framework-job-expire.rst Outdated Show resolved Hide resolved
djwfyi
djwfyi reviewed Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@djwfyi djwfyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swap it's for its in two spots.

source/administration/batch-framework-job-expire.rst Outdated Show resolved Hide resolved
source/administration/batch-framework-job-expire.rst Outdated Show resolved Hide resolved
@ravindk89
Copy link
Collaborator Author

@krisis changes updating shortly, staging also updated.

krisis
krisis approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@krisis krisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Batch expiration feature docs look good to me.

@ravindk89 ravindk89 merged commit a065b7a into main Jan 2, 2024
@ravindk89 ravindk89 deleted the DOCS-1083 branch January 2, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djwfyi djwfyi djwfyi approved these changes

@krisis krisis krisis approved these changes

@feorlen feorlen Awaiting requested review from feorlen

@vadmeste vadmeste Awaiting requested review from vadmeste

Assignees

@ravindk89 ravindk89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RELEASE] MinIO Server RELEASE.2023-12-02T10-51-33Z
4 participants
@ravindk89 @vadmeste @krisis @djwfyi