Add in-place/no-downtime upgrade support #738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3e0e71c
to
3c28cb6
Compare
7ba04f8
to
dc57a28
Compare
51d790b
to
d87feac
Compare
|
|
||
| install_directpv "./kubectl-directpv_4.0.2_linux_amd64" "${pod_count}" | ||
| install_directpv "${DIRECTPV_DIR}/kubectl-directpv" "${pod_count}" # here upgrade is done | ||
|
|
There was a problem hiding this comment.
can we check the controller and node-server image after the upgrade?
There was a problem hiding this comment.
It is already covered in https://github.com/minio/directpv/pull/738/files#diff-7ed495c18e646e4ee18df0ec70098407224c7b618d51cec5c06693a14d53fdabR467 i.e. in a normal upgrade case. If test_upgrade fails, this test has no meaning.
Let me know we still need to add the check here.
functests/multi-node-tests.sh
Outdated
| echo | ||
|
|
||
| # cleanup_directpv | ||
| # ssh_cmd "${MASTER_VM_IP}" "ACTIVE_NODES=${ACTIVE_NODES} ./functests/run-migration-tests.sh v2.0.9" |
There was a problem hiding this comment.
can we remove these comments?
fd60d78
to
6967d03
Compare
a5beaa5
to
e5b8098
Compare
e5b8098
to
c0d4be6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #266
Depends on #756