Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url cleanup upgrade #148

Open
wants to merge 14 commits into
base: release/0.2.0
Choose a base branch
from
Open

url cleanup upgrade #148

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
756fc02
#16
Mar 13, 2021
3720c2e
CR fixes
Mar 13, 2021
f05a3aa
Merge branch 'release/0.2.0' of https://github.com/mini-services/mini…
Mar 13, 2021
e3d2c32
resolve conflict
Mar 13, 2021
9369ee5
Update .env.development
shay123g Mar 16, 2021
6ab1042
Update src/services/storage/drivers/inMemory/index.ts
shay123g Mar 16, 2021
71e967f
fix test & config
Mar 16, 2021
ad41274
Update src/config/validate.ts
shay123g Mar 22, 2021
2278c4a
Update src/config/validate.ts
shay123g Mar 22, 2021
ff7533a
.
Mar 23, 2021
2cf1176
fix imports
Mar 23, 2021
0198804
Merge branch 'release/0.2.0' of https://github.com/mini-services/mini…
Mar 28, 2021
7c53866
fix tests
Mar 28, 2021
75c9a8f
fix tests
Mar 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/services/storage/drivers/inMemory/index.ts 
Co-authored-by: lesagi <[email protected]>
  • Loading branch information
@shay123g @lesagi
shay123g and lesagi committed Mar 16, 2021
commit 6ab10423ef84f731abc66437adece759dba8d008
3 changes: 1 addition & 2 deletions src/services/storage/drivers/inMemory/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ export class InMemoryStorage implements StorageDriver {
let deletedCount = 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment in the PR


this.storage.data.urls.forEach((storedUrl) => {
let relativeDate = new Date(storedUrl.createdAt).getTime()
if (deleteFrom === 'update') relativeDate = new Date(storedUrl.updatedAt).getTime()
const relativeDate = new Date(deleteFrom === 'update' ? storedUrl.updatedAt : storedUrl.createdAt).getTime()
if (relativeDate <= deleteBefore) {
this.storage.data.urls.delete(storedUrl.id)
deletedCount++
Expand Down