[CSM] Add settings API

[HybridDog]

l noticed that minetest.setting_get doesn't work.
l need this function to get the player name and other settings.
It's executed at load time, so according to the documentation it should work.

[Desour]

Also settingtypes.txt doesn't work yet.
related: #5394

[nerzhul]

sorry, but it's a bad usecase to use settings to get player name. We will have a lcoalplayer reference instead for this when roadmap 2 will be finished

[rubenwardy]

Are there any usecases for this apart from mod settings? Might be worth only letting CSM access settings starting with client.

[HybridDog]

You may want to get the smooth lighting setting and whatnot.

[nerzhul]

@HybridDog i think we can offer setting getter to mods, but not setting setter

[HybridDog]

This issue is about the getter.

[sofar]

We want to make sure mods (sent by the server) can't scrape all user settings and send them to the server. So indeed what @rubenwardy said, you probably only want to allow a few settings to be read, if any.

[paramat]

so according to the documentation it should work.

That's not official documentation of the function, that may just be copy-paste.
Many settings are probably best hidden from CSM.

[raymoo]

What if mods can only read specific settings plus all settings with names that are modname.settingname?

[paramat]

Mods may have settings that control things that need to be secret on a server. Likewise we need to be careful about accessing other settings a client should not know and could abuse.

[raymoo]

If it's a secret then don't send it to the client.

[Desour]

Related: #5941

[paramat]

1+ year bump, any core dev support?

[Desour]

The link in the first post is outdated, here's a permalink:

minetest/doc/client_lua_api.txt

Lines 100 to 101 in b6adb7f

	`minetest.setting_get(name)` and `minetest.setting_getbool(name)` can be used
	to read custom or existing settings at load time, if necessary.

[paramat]

The future of CSM is highly uncertain at the moment. I feel it's best to wait until we know SSCSM is going ahead before adding new CSM features (as it may be wasted work). So i am 👎 until SSCSM progresses.