Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed demo app #252

Merged
merged 2 commits into from
May 11, 2021
Merged

fix: Fixed demo app #252

merged 2 commits into from
May 11, 2021

Conversation

fg-mindee
Copy link
Contributor

This PR introduces the following modifications:

  • fixed demo app with the recent changes in model call method
  • enforced training=False in evaluation and analysis scripts

Any feedback is welcome!

@fg-mindee fg-mindee added ext: scripts Related to scripts folder ext: demo Related to demo folder labels May 11, 2021
@fg-mindee fg-mindee added this to the 0.2.0 milestone May 11, 2021
@fg-mindee fg-mindee self-assigned this May 11, 2021
Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #252 (a112c8f) into main (ffe3c2f) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
+ Coverage   96.93%   96.98%   +0.05%     
==========================================
  Files          45       45              
  Lines        1923     1923              
==========================================
+ Hits         1864     1865       +1     
+ Misses         59       58       -1     
Flag Coverage Δ
unittests 96.98% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tr/models/detection/differentiable_binarization.py 94.06% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffe3c2f...a112c8f. Read the comment docs.

@fg-mindee fg-mindee merged commit 650c4ad into main May 11, 2021
@fg-mindee fg-mindee deleted the app-fix branch May 11, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: demo Related to demo folder ext: scripts Related to scripts folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants