Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix eval scripts + possible overflow in Resize #1715

Merged
merged 7 commits into from
Oct 1, 2024

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Sep 3, 2024

This PR:

  • fix for eval scripts with keeping aspect ratio / symmetric pad - optional
  • tf: fix deprecated
  • fix small overflow

Any feedback is welcome 🤗

@felixdittrich92 felixdittrich92 self-assigned this Sep 3, 2024
@felixdittrich92 felixdittrich92 added type: bug Something isn't working module: transforms Related to doctr.transforms framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend labels Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.46%. Comparing base (9045dcf) to head (99222b4).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
doctr/transforms/modules/pytorch.py 50.00% 2 Missing ⚠️
doctr/transforms/modules/tensorflow.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1715      +/-   ##
==========================================
+ Coverage   96.40%   96.46%   +0.06%     
==========================================
  Files         164      164              
  Lines        7782     7780       -2     
==========================================
+ Hits         7502     7505       +3     
+ Misses        280      275       -5     
Flag Coverage Δ
unittests 96.46% <71.42%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixdittrich92 felixdittrich92 changed the title [Bug] Overflow detection training [Bug] Fix multi target Resize + Overflow + allow built-in datasets Sep 4, 2024
@felixdittrich92 felixdittrich92 changed the title [Bug] Fix multi target Resize + Overflow + allow built-in datasets [Bug] Fix multi target Resize + Overflow Sep 4, 2024
@felixdittrich92 felixdittrich92 changed the title [Bug] Fix multi target Resize + Overflow [Bug] Fix eval scripts + possible overflow in Resize Sep 5, 2024
@felixdittrich92 felixdittrich92 marked this pull request as ready for review September 5, 2024 09:32
@felixdittrich92
Copy link
Contributor Author

failing test depends on #1717

@felixdittrich92 felixdittrich92 added this to the 0.9.1 milestone Sep 25, 2024
@felixdittrich92 felixdittrich92 merged commit da88880 into mindee:main Oct 1, 2024
79 of 81 checks passed
@felixdittrich92 felixdittrich92 deleted the train-clip-issue branch October 1, 2024 08:42
@felixdittrich92 felixdittrich92 modified the milestones: 0.9.1, 0.10.0 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend module: transforms Related to doctr.transforms type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants