Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[orientation] Enable usage of custom trained orientation models #1708

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

felixdittrich92
Copy link
Contributor

This PR:

  • Add ability that users can train and use there own orientation models
  • Open interface to load custom orient models
  • Add corresponding doc section and tests

Any feedback is welcome 🤗

NOTE:
Overwriting is i think a temp solution to avoid blowing up the ocr_predictor args until we have a solution for a better interface.

Request: #1698

@felixdittrich92 felixdittrich92 added topic: documentation Improvements or additions to documentation type: enhancement Improvement module: models Related to doctr.models ext: tests Related to tests folder ext: references Related to references folder topic: character classification Related to the task of character classification ext: docs Related to docs folder labels Aug 28, 2024
@felixdittrich92 felixdittrich92 added this to the 0.9.1 milestone Aug 28, 2024
@felixdittrich92 felixdittrich92 self-assigned this Aug 28, 2024
@felixdittrich92 felixdittrich92 linked an issue Aug 28, 2024 that may be closed by this pull request
3 tasks

from doctr.datasets import VOCABS

from ...utils import load_pretrained_params

__all__ = [
"MobileNetV3",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's required for the isinstance check in classification.zoo

@felixdittrich92 felixdittrich92 marked this pull request as ready for review August 28, 2024 09:13
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (4434213) to head (64e8f8c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1708      +/-   ##
==========================================
+ Coverage   96.41%   96.42%   +0.01%     
==========================================
  Files         164      164              
  Lines        7777     7782       +5     
==========================================
+ Hits         7498     7504       +6     
+ Misses        279      278       -1     
Flag Coverage Δ
unittests 96.42% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR, looks good to me !

@felixdittrich92 felixdittrich92 merged commit 9045dcf into mindee:main Aug 29, 2024
81 checks passed
@felixdittrich92 felixdittrich92 deleted the own-orient-models branch August 29, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: docs Related to docs folder ext: references Related to references folder ext: tests Related to tests folder module: models Related to doctr.models topic: character classification Related to the task of character classification topic: documentation Improvements or additions to documentation type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[orientation] Make it possible to use your own trained orientation models
2 participants