Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.14.4 upgrade #4

Merged
merged 1 commit into from
Apr 12, 2021
Merged

v0.14.4 upgrade #4

merged 1 commit into from
Apr 12, 2021

Conversation

spkane
Copy link
Contributor

@spkane spkane commented Jan 19, 2021

This gets the code compiling with the newest terraform libraries.

In general it appears to create the local file properly, but I could not actually get terraform to respect the lock with a local state file.

Might try to test it with S3 and Dynamo DB when I get a moment. My guess it that there is now a bit more logic on determining wether the lock file is still valid.

@jaredledvina
Copy link
Contributor

@spkane - Just curious if you knew of any work left here. I tested this with a rather simple S3 and DnyamoDB lock setup and it seems to work. I'd be interested in helping if I can.

@spkane
Copy link
Contributor Author

spkane commented Apr 11, 2021

@jaredledvina As far as I know this did the job, but that work was all the time I had to spend on it. I think this project is dead, but this could be merged in if indeed it is both complining and working with current releases.

@jaredledvina
Copy link
Contributor

Ah great, yeah worked for me with the S3 state and DynamoDB lock setup on 0.14.10 on Friday actually.

@minamijoyo if you happen to still maintain this, it'd be great to see it merged in and I'm happy to help test it further if you would like to see anything specifically verified. Thanks for the project!

Copy link
Owner

@minamijoyo minamijoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@minamijoyo minamijoyo merged commit 0303f2c into minamijoyo:master Apr 12, 2021
@minamijoyo
Copy link
Owner

@spkane @jaredledvina Thank you for your work.

@jaredledvina Could you share you use-case if possible? Because I originally wrote the tflock for refactoring, but now I'm using the tfmigrate for it. I'm just curious when the tflock useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants