Include FetchInterceptor in binding of setupServer (enable basic v18 native fetch support)
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rver This actually seems to work fine, even without any tests or changes necessary. However, for tests to pass with Node v18 and also I think to support some https cases, the PR from mswjs/interceptors should be merged: mswjs/interceptors#283
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the minimal change to allow using native fetch in node v18. All it does is add another interceptor to
createServer. This might not be desirable for package size changes, idk.This does not depend on mswjs/interceptors#283 but that will allow us to actually test in node v18 and also fix some specific scenarios that don't work out of the box (https I think).