Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@avleenk2312 @tomkimpson This PR will completely restructure this package because we had badly defined things too specific and so it does this now as general.jl which defines all functions for
::AbstractStochasticFloat
and types.jl which defines only what's necessary for a specific type, e.g.BFloat16sr
is justAs you see this frees a lot of lines of code that were previously used to redefine for every type which could be just collected into a single more general formulation.
Draft for now as I still need to adapt all tests but it alsoDONE.fixes #72 #70 #63
@madnanabid