Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README documentation explaining how to support non-int database primary keys #92

Merged
merged 3 commits into from
Nov 19, 2020
Merged

Add README documentation explaining how to support non-int database primary keys #92

merged 3 commits into from
Nov 19, 2020

Conversation

anaulin
Copy link
Contributor

@anaulin anaulin commented Nov 18, 2020

This PR documents a workaround for non-int authenticatable primary keys, as discussed in #91 .

Let me know what you think, and feel free to edit directly. 🙏

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Owner

@mikker mikker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to add this, @anaulin!

README.md Outdated Show resolved Hide resolved
Copy link
Owner

@mikker mikker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions for edits.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@anaulin
Copy link
Contributor Author

anaulin commented Nov 18, 2020

@mikker I incorporated your suggestions, and added a note about add_reference, as @Foamer suggested. Please have another look.

@mikker mikker merged commit bb53755 into mikker:master Nov 19, 2020
@mikker
Copy link
Owner

mikker commented Nov 19, 2020

Very nice, thank you for helping out! 💙💚💛💜❤️

@anaulin anaulin deleted the uuid-authenticatable-id-docs branch November 19, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants