Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constraint for config/routes.rb #227

Closed
wants to merge 7 commits into from
Closed

Constraint for config/routes.rb #227

wants to merge 7 commits into from

Conversation

tdegrunt
Copy link
Contributor

Should fix #139

  • Renames the constraint to Passwordless::Constraint
  • Added tests
  • Added docs

@henrikbjorn
Copy link
Contributor

Could the lambda be made optional ?

@henrikbjorn
Copy link
Contributor

Also would be cool to have a negative of it. E.g. I want to disallow people when they are logged in.

@tdegrunt
Copy link
Contributor Author

Updated it to support both suggestions. I had thought about making the proc optional, but I would've been okay with just using -> { true }, but this is nicer.

@mikker
Copy link
Owner

mikker commented May 28, 2024

Included in #228. Thank you for contributing to Passwordless!

@mikker mikker closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Constraint helpers for config/routes.rb
3 participants
@tdegrunt @henrikbjorn @mikker