Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown email sender config #225

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Unknown email sender config #225

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6f442d4
Add Unknown Address mailer to default mailers
Dakota-Schramm May 3, 2024
72f8d9b
Add config option for sending paranoid email
Dakota-Schramm May 3, 2024
72f461a
Add NL to end of unknown_address text
Dakota-Schramm May 3, 2024
917ffdb
Move method for after config paranoid directly into call_after_sessio…
Dakota-Schramm May 3, 2024
ea1ba19
Add test for sending paranoid email with send_paranoid_email config e…
Dakota-Schramm May 3, 2024
5826805
Remove whitespace. Revert schema update
Dakota-Schramm May 3, 2024
686e121
Fix default text added with unknown_address mailer
Dakota-Schramm May 3, 2024
c999b64
Remove extra whitespace
Dakota-Schramm May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move method for after config paranoid directly into call_after_sessio… 
…n_save
  • Loading branch information
@Dakota-Schramm
Dakota-Schramm committed May 3, 2024
commit 917ffdbd7ff725be7df1073fc5a6d637eb496c54
9 changes: 4 additions & 5 deletions app/controllers/passwordless/sessions_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,7 @@ def normalized_email_param
def handle_resource_not_found
if Passwordless.config.paranoid
@resource = authenticatable_class.new(email: normalized_email_param)

if Passwordless.config.send_paranoid_email
@skip_after_session_save_callback = true
end
@skip_after_session_save_callback = true
else
raise(
ActiveRecord::RecordNotFound,
Expand All @@ -217,7 +214,9 @@ def handle_resource_not_found

def call_after_session_save
if @skip_after_session_save_callback
Passwordless.config.after_session_paranoid.call(@session, request)
if Passwordless.config.send_paranoid_email
Mailer.unknown_address(@session).deliver_now
end
elsif Passwordless.config.after_session_save.arity == 2
Passwordless.config.after_session_save.call(@session, request)
else
Expand Down
8 changes: 1 addition & 7 deletions lib/passwordless/config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,7 @@ class Configuration
Mailer.sign_in(session, session.token).deliver_now
end
)
option(
:after_session_paranoid,
default: lambda do |session, _request|
Mailer.unknown_address(session).deliver_now
end
)


option :paranoid, default: false
option :send_paranoid_email, default: false

Expand Down