Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass token to email subject translation #224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

luiscobot
Copy link
Contributor

I think it is better to have the option to pass the token in the email subject, so we do not need to even open the email, maybe we can only see the notification in the phone and right there will be the token.

With this change we could use the token in the email subject locales key.

CleanShot 2024-04-26 at 19 14 22@2x

@mikker
Copy link
Owner

mikker commented May 14, 2024

Thank you for contributing this.

Does it complain if you don't include %{token} in your subject, like we don't in the default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants