Drop explicit I18n load path configuration #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is currently a problem with locales load order such that in production, passwordless locale files come after the application locale files in the I18n load path This prevents the application from overriding any translations Rails engines don't need to explicitly configure this at least since 5.1.4 (the current minimum requirement) - https://api.rubyonrails.org/v5.1.4/classes/Rails/Engine.html
|
We tested this in our own production specifically for the subject line and found that this change works |
|
Great, thank you! Must be a leftover from way back when. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a problem with locales load order such that in production, passwordless locale files come after the application locale files in the I18n load path
This prevents the application from overriding any translations
Rails engines don't need to explicitly configure this at least since 5.1.4 (the current minimum requirement)