Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parent controller option #199

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

yenshirak
Copy link
Contributor

@yenshirak yenshirak commented Jan 19, 2024

I think this makes sense because it follows the same pattern as parent_mailer. It is possible to extract the base controller logic into a concern and include that in a custom Passwordless controller but using an option would be more convenient.

@mikker
Copy link
Owner

mikker commented Jan 24, 2024

Do you have a need for this in your app(s)?

@yenshirak
Copy link
Contributor Author

Yes. It's used on the admin interface so the parent should be the admin base controller.

@mikker
Copy link
Owner

mikker commented Jan 24, 2024

Got it. Thanks!

@mikker mikker merged commit 02d3899 into mikker:master Jan 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants