Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass redirect_to options when signing out #143

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

bcasci
Copy link
Contributor

@bcasci bcasci commented Jun 9, 2023

@mikker This is a followup to my earlier PR.

First, I neglected to notice that the redirect_to options needed to be used on session destroy as well.

Second, in QA testing in my own app, I noticed some unusual behavior. This had to with the Rails redirect_to method manipulating the options hash that's passed into it. Since these options are passed by reference, the Passwordless configuration was being changed on the fly by Rails. I got around that by calling .dup on those options before passing them to redirect_to.

@mikker
Copy link
Owner

mikker commented Jun 9, 2023

Thank you for following up with fixes.

@mikker mikker merged commit 11e59cc into mikker:master Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants