Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use form_with, requre email, handle rails 7 form redirect #128

Merged
merged 8 commits into from
Nov 30, 2022
Merged

use form_with, requre email, handle rails 7 form redirect #128

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9557cdd
use form_with, requre email.
yshmarov Nov 8, 2022
1b8fc6f
add data turbo false to ensure redirect in rails 7
yshmarov Nov 9, 2022
414989a
validate regex in example
yshmarov Nov 9, 2022
753e713
fix typo and consequently specs
yshmarov Nov 9, 2022
f52c332
add ua.yml i18n
yshmarov Nov 13, 2022
70ba88c
Delete ua.yml
yshmarov Nov 30, 2022
dd33703
Update CHANGELOG.md
yshmarov Nov 30, 2022
bd98de1
Update CHANGELOG.md
mikker Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Next Next commit
use form_with, requre email. 
form_with allows more options than form_for; don't let the html form submit null email
  • Loading branch information
@yshmarov
yshmarov committed Nov 8, 2022
commit 9557cdde8a6015ad9db0fb5840278cf9d4c6d2eb
4 changes: 2 additions & 2 deletions app/views/passwordless/sessions/new.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<%= form_for @session, url: send(Passwordless.mounted_as).sign_in_path do |f| %>
<%= form_with, model: @session, url: send(Passwordless.mounted_as).sign_in_path do |f| %>
<% email_field_name = :"passwordless[#{@email_field}]" %>
<%= text_field_tag email_field_name, params.fetch(email_field_name, nil) %>
<%= text_field_tag email_field_name, params.fetch(email_field_name, nil), required: true %>
<%= f.submit I18n.t('passwordless.sessions.new.submit') %>
<% end %>
2 changes: 1 addition & 1 deletion test/dummy/app/views/registrations/new.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<%= form_for @user, url: registrations_path do |f| %>
<%= form_with model: @user, url: registrations_path do |f| %>
<%= f.label :email %>
<%= f.email_field :email %>
<%= f.submit %>
Expand Down