migrated CI from Travis CI to GitHub Actions workflow, to get CI working again. #109
+26
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This repository is currently using https://travis-ci.org/. However, https://travis-ci.org/ was terminated on June 15, 2021. > Since June 15th, 2021, the building on travis-ci.org is ceased. Please use travis-ci.com from now on. > https://travis-ci.org/github/mikker/passwordless Therefore, I moved to GitHub Action to restart CI. The ruby 2.5 was excluded from CI because it is EOL. I tried to set the repository secret `CODECOV_TOKEN` so that reports will be sent to codecov, but I can't set the token, so I checked test_helper so that CI can be run even if it is not specified.
|
This is wonderful! Thank you very much for setting this up 💙💚💛💜❤️ |
madogiwa0124
added a commit
to madogiwa0124/passwordless
that referenced
this pull request
Dec 21, 2021
Currently, CI is only triggered by push, so PR from a forked repository will not run CI. Therefore, added `pull_request` to `on`. Also, if simply add `pull_request`, it will be executed twice with `push`, so we modified `push` to be executed only in the `master` branch. related: mikker#109
This was referenced Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to migrate to GitHub Action, please close this PR if considering migrating to travis-ci.com, etc.
How about this PR?
Description
Passwordless uses https://travis-ci.org/, but https://travis-ci.org/ expires on June 15, 2021, so it appears that CI is not currently up and running.
In this PR configuration file, we load the repository secret
CODECOV_TOKENso that reports are sent to codecov. But since I can't set the token, I checked in test_helper so that I can run CI without specifying it.https://docs.github.com/en/actions/security-guides/encrypted-secrets
I also excluded ruby2.5, which is EOL, from the CI.
Test
I have confirmed that the Github Action runs and succeeds in my repository.
https://github.com/madogiwa0124/passwordless/actions/runs/1566667538