Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging modal documents #642

Closed
Paril opened this issue Jul 26, 2024 · 4 comments
Closed

Debugging modal documents #642

Paril opened this issue Jul 26, 2024 · 4 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@Paril
Copy link
Contributor

Paril commented Jul 26, 2024

If a document is loaded with the Modal flag, it can't be debugged with Rml::Debugger as the modal eats all of the inputs. Currently the only workaround I can spot is just removing Modal when the debugger is visible.

@mikke89 mikke89 added the enhancement New feature or request label Jul 28, 2024
mikke89 added a commit that referenced this issue Jul 28, 2024
@mikke89
Copy link
Owner

mikke89 commented Jul 28, 2024

Thanks for reporting, I see that the debugger doesn't receive focus when another document has modal focus. Another workaround that seemed to work for me is to make a separate context for the debugger.

Better than dealing with workarounds though, I took a stab at properly fixing this.

Could you help test this branch and see how it works for you (and checking for no regressions), cheers: https://github.com/mikke89/RmlUi/commits/debugger-modal/

@Paril
Copy link
Contributor Author

Paril commented Jul 30, 2024

Thanks, I will test this out when I have time to port us over to master. We're still using an older version internally (5.x) and haven't upgraded to the current master 6.x yet since we are using some of my PRs that haven't been merged in yet, so it may be a little bit before I can test this myself. I need to get to re-opening those!

EDIT: actually I'll do this now. The main issue I ran into trying to get this to compile is TextInputContent.h has a wrong #include directive; the rest of the project uses relative includes, but for some reason this one is absolute & checking system includes:

#include <RmlUi/Core/StringUtilities.h>

Using this worked, though:

#include "StringUtilities.h"

@Paril
Copy link
Contributor Author

Paril commented Jul 30, 2024

Confirmed fixed with the given branch though; thanks!

mikke89 added a commit that referenced this issue Jul 30, 2024
@mikke89 mikke89 added the bug Something isn't working label Jul 30, 2024
@mikke89
Copy link
Owner

mikke89 commented Jul 30, 2024

Thanks for testing! Merged to master just now, should be fixed in 263328a.

@mikke89 mikke89 closed this as completed Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants